Messages in this thread | | | Date | Tue, 25 Aug 2020 08:47:21 -0700 | From | Andi Kleen <> | Subject | Re: [RFC] perf/jevents: Add new structure to pass json fields. |
| |
On Tue, Aug 25, 2020 at 01:10:41PM +0530, Kajol Jain wrote: > This patch adds new structure called 'json_event' inside jevents.h > file to improve the callback prototype inside jevent files. > Initially, whenever user want to add new field, they need to update > in all function callback which make it more and more complex with > increased number of parmeters. > With this change, we just need to add it in new structure 'json_event'.
Looks good to me. Thanks.
I wouldn't consolidate with event_struct, these are logically different layers.
Reviewed-by: Andi Kleen <ak@linux.intel.com>
| |