Messages in this thread | | | Date | Mon, 24 Aug 2020 14:04:38 +0200 | From | Boris Brezillon <> | Subject | Re: [RESEND PATCH v3 7/8] mtd: spi-nor: Convert cadence-quadspi to use spi-mem framework |
| |
On Mon, 24 Aug 2020 17:14:56 +0530 Vignesh Raghavendra <vigneshr@ti.com> wrote:
> Hi Jan, > > On 8/24/20 11:25 AM, Jan Kiszka wrote: > [...] > > >> +MODULE_AUTHOR("Vignesh Raghavendra <vigneshr@ti.com>"); > >> > > On the AM65x, this changes mtd->name (thus mtd-id for > > parser/cmdlinepart) from 47040000.spi.0 to spi7.0. The besides having to > > deal with both names now, "spi7" sounds like it could easily change > > again if someone plugs or unplugs some other SPI device. Is this intended? > > > > You could use DT aliases to make sure OSPI0 is always at given bus num > (say spi7): > > aliases { > spi7 = &ospi0; > };
FWIW, we've added the ->get_name() method [1][2] to avoid such regressions.
[1]https://elixir.bootlin.com/linux/latest/source/include/linux/spi/spi-mem.h#L218 [2]https://elixir.bootlin.com/linux/latest/source/drivers/spi/spi-fsl-qspi.c#L810
| |