Messages in this thread | | | Subject | Re: [PATCH 10/11] ima: Don't ignore errors from crypto_shash_update() | From | Mimi Zohar <> | Date | Mon, 24 Aug 2020 09:02:22 -0400 |
| |
On Thu, 2020-06-18 at 18:04 +0200, Roberto Sassu wrote: > Errors returned by crypto_shash_update() are not checked in > ima_calc_boot_aggregate_tfm() and thus can be overwritten at the next > iteration of the loop. This patch adds a check after calling > crypto_shash_update() and returns immediately if the result is not zero. > > Cc: stable@vger.kernel.org > Fixes: 3323eec921efd ("integrity: IMA as an integrity service provider") > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Verification of the boot_aggregate will fail, but yes this should be fixed. This patch and the next should be moved up front to the beginning of the patch set.
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
thanks,
Mimi
| |