Messages in this thread | | | Date | Sat, 22 Aug 2020 11:44:02 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH] iio: adc: adi-axi-adc: Use kobj_to_dev() instead of container_of() |
| |
On Thu, 20 Aug 2020 16:07:04 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Thu, Aug 20, 2020 at 4:05 PM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > On Thu, Aug 20, 2020 at 12:10 PM Alexandru Ardelean > > <ardeleanalex@gmail.com> wrote: > > > On Thu, Aug 20, 2020 at 6:04 AM Tian Tao <tiantao6@hisilicon.com> wrote: > > > > > - struct device *dev = container_of(kobj, struct device, kobj); > > > > + struct device *dev = kobj_to_dev(kobj); > > > And now this can be one line since dev is not used separately. > > On the other hand perhaps one object per line is better to read. >
Indeed, not clear one way or the others, so I'm going with the path of least resistance. Applied as is.
Thanks,
Jonathan
| |