lkml.org 
[lkml]   [2020]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.19 83/92] mfd: dln2: Run event handler loop under spinlock
On Fri, Aug 21, 2020 at 11:14:16AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Aug 21, 2020 at 12:06:45PM +0300, Andy Shevchenko wrote:
> > On Fri, Aug 21, 2020 at 10:26 AM Pavel Machek <pavel@denx.de> wrote:
> > > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > >
> > > > [ Upstream commit 3d858942250820b9adc35f963a257481d6d4c81d ]
> > > >
> > > > The event handler loop must be run with interrupts disabled.
> > > > Otherwise we will have a warning:
> > > ...
> > > > Recently xHCI driver switched to tasklets in the commit 36dc01657b49
> > > > ("usb: host: xhci: Support running urb giveback in tasklet
> > > > context").
> > >
> > > AFAICT, 36dc01657b49 is not included in 4.19.141, so this commit
> > > should not be needed, either.
> >
> > I'm wondering if there are any other USB host controller drivers that
> > use URB giveback in interrupt enabled context.
>
> Almost all do.

Sorry, read that the wrong way, most have interrupts disabled, so this
change should be fine.

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-08-21 11:15    [W:0.151 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site