Messages in this thread | | | Subject | Re: [PATCH v6 5/6] PCI: uniphier: Add iATU register support | From | Kunihiko Hayashi <> | Date | Fri, 21 Aug 2020 16:05:16 +0900 |
| |
On 2020/08/18 1:48, Rob Herring wrote: > On Fri, Aug 7, 2020 at 4:25 AM Kunihiko Hayashi > <hayashi.kunihiko@socionext.com> wrote: >> >> This gets iATU register area from reg property. In Synopsys DWC version >> 4.80 or later, since iATU register area is separated from core register >> area, this area is necessary to get from DT independently. >> >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> --- >> drivers/pci/controller/dwc/pcie-uniphier.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c >> index 55a7166..93ef608 100644 >> --- a/drivers/pci/controller/dwc/pcie-uniphier.c >> +++ b/drivers/pci/controller/dwc/pcie-uniphier.c >> @@ -471,6 +471,11 @@ static int uniphier_pcie_probe(struct platform_device *pdev) >> if (IS_ERR(priv->pci.dbi_base)) >> return PTR_ERR(priv->pci.dbi_base); >> >> + priv->pci.atu_base = >> + devm_platform_ioremap_resource_byname(pdev, "atu"); >> + if (IS_ERR(priv->pci.atu_base)) >> + priv->pci.atu_base = NULL; > > Keystone has the same 'atu' resource setup. Please move its code to > the DW core and use that.
There are some platforms that pci.atu_base is set by other way. The 'atu' code shouldn't be conflicted with the following existing code.
drivers/pci/controller/dwc/pci-keystone.c: atu_base = devm_platform_ioremap_resource_byname(pdev, "atu"); drivers/pci/controller/dwc/pci-keystone.c: pci->atu_base = atu_base; drivers/pci/controller/dwc/pcie-designware.c: pci->atu_base = pci->dbi_base + DEFAULT_DBI_ATU_OFFSET; drivers/pci/controller/dwc/pcie-intel-gw.c: pci->atu_base = pci->dbi_base + data->pcie_atu_offset; drivers/pci/controller/dwc/pcie-tegra194.c: pci->atu_base = devm_ioremap_resource(dev, atu_dma_res);
So I'm not sure where to move the code in the DW core. Is there any idea?
Thank you,
--- Best Regards Kunihiko Hayashi
| |