lkml.org 
[lkml]   [2020]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 179/232] libnvdimm/security: fix a typo
    Date
    From: Jane Chu <jane.chu@oracle.com>

    [ Upstream commit dad42d17558f316e9e807698cd4207359b636084 ]

    commit d78c620a2e82 ("libnvdimm/security: Introduce a 'frozen' attribute")
    introduced a typo, causing a 'nvdimm->sec.flags' update being overwritten
    by the subsequent update meant for 'nvdimm->sec.ext_flags'.

    Link: https://lore.kernel.org/r/1596494499-9852-1-git-send-email-jane.chu@oracle.com
    Fixes: d78c620a2e82 ("libnvdimm/security: Introduce a 'frozen' attribute")
    Cc: Dan Williams <dan.j.williams@intel.com>
    Reviewed-by: Dave Jiang <dave.jiang@intel.com>
    Signed-off-by: Jane Chu <jane.chu@oracle.com>
    Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/nvdimm/security.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/nvdimm/security.c b/drivers/nvdimm/security.c
    index 4cef69bd3c1bd..8f3971cf16541 100644
    --- a/drivers/nvdimm/security.c
    +++ b/drivers/nvdimm/security.c
    @@ -457,7 +457,7 @@ void __nvdimm_security_overwrite_query(struct nvdimm *nvdimm)
    clear_bit(NDD_WORK_PENDING, &nvdimm->flags);
    put_device(&nvdimm->dev);
    nvdimm->sec.flags = nvdimm_security_flags(nvdimm, NVDIMM_USER);
    - nvdimm->sec.flags = nvdimm_security_flags(nvdimm, NVDIMM_MASTER);
    + nvdimm->sec.ext_flags = nvdimm_security_flags(nvdimm, NVDIMM_MASTER);
    }

    void nvdimm_security_overwrite_query(struct work_struct *work)
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-08-20 11:33    [W:3.551 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site