Messages in this thread | | | Date | Sun, 2 Aug 2020 14:00:15 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v4 1/4] power: supply: core: add quick charge type property |
| |
On Mon 2020-07-20 13:47:14, Qiwu Huang wrote: > From: Qiwu Huang <huangqiwu@xiaomi.com> > > Reports the kind of quick charge type based on > different adapter power. > > Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com> > --- > Documentation/ABI/testing/sysfs-class-power | 21 +++++++++++++++++++++ > drivers/power/supply/power_supply_sysfs.c | 1 + > include/linux/power_supply.h | 10 ++++++++++ > 3 files changed, 32 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > index 216d61a22f1e..dd3773dcf16a 100644 > --- a/Documentation/ABI/testing/sysfs-class-power > +++ b/Documentation/ABI/testing/sysfs-class-power > @@ -708,3 +708,24 @@ Description: > > Access: Read > Valid values: 1-31 > + > +What: /sys/class/power_supply/<supply_name>/quick_charge_type > +Date: Jul 2020 > +Contact: Fei Jiang <jiangfei1@xiaomi.com> > + Description: > + Reports the kind of quick charge type based on different adapter power. > + Different quick charge type represent different charging power. > + QUICK_CHARGE_NORMAL : Charging Power <= 10W > + QUICK_CHARGE_FAST : 10W < Charging Power <= 20W > + QUICK_CHARGE_FLASH : 20W < Charging Power <= 30W > + QUICK_CHARGE_TURBE : 30W < Charging Power <= 50W > + QUICK_CHARGE_SUPER : Charging Power > 50W > + > + Access: Read-Only > + Valid values: > + 0: QUICK_CHARGE_NORMAL, > + 1: QUICK_CHARGE_FAST, > + 2: QUICK_CHARGE_FLASH, > + 3: QUICK_CHARGE_TURBE, > + 4: QUICK_CHARGE_SUPER.
NAK.
Just expose value in watts or something... People are talking about > 100W charging, no need to go with fast/turbe/super/hyper/nonsense.
BTW fast charge is already "well defined", and what you call Normal is usually fast charge.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |