lkml.org 
[lkml]   [2020]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: sparse warnings in vop
On Sun, Aug 2, 2020 at 9:25 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Sunday, August 2, 2020, Michael S. Tsirkin <mst@redhat.com> wrote:
>>
>> Hi!
>> Building vop with make C=1 produces the following:
>>
>> CHECK drivers/misc/mic/vop/vop_main.c
>> drivers/misc/mic/vop/vop_main.c:551:58: warning: incorrect type in argument 1 (different address spaces)
>> drivers/misc/mic/vop/vop_main.c:551:58: expected void const volatile [noderef] __iomem *addr
>> drivers/misc/mic/vop/vop_main.c:551:58: got restricted __le64 *
>> drivers/misc/mic/vop/vop_main.c:560:49: warning: incorrect type in argument 1 (different address spaces)
>> drivers/misc/mic/vop/vop_main.c:560:49: expected struct mic_device_ctrl *dc
>> drivers/misc/mic/vop/vop_main.c:560:49: got struct mic_device_ctrl [noderef] __iomem *dc
>> drivers/misc/mic/vop/vop_main.c:579:49: warning: incorrect type in argument 1 (different address spaces)
>> drivers/misc/mic/vop/vop_main.c:579:49: expected struct mic_device_ctrl *dc
>> drivers/misc/mic/vop/vop_main.c:579:49: got struct mic_device_ctrl [noderef] __iomem *dc
>>
>> Would be nice to fix to silence the noise, but I'm not 100% sure
>> what the right thing to do here is. Tag struct members with __iomem or
>> cast with __force on use?
>
>
>
> Sounds right to me.

I don't think either of the above, adding __force is almost always wrong,
and __iomem never applies to struct members, only to pointers.

The first problem I see is with:

static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl *dc)

The argument needs to be an __iomem pointer. In the structure, the
first member has type __le64, which gets mentioned in the warning.
We usually use __u64 instead (or don't use structures at all for __iomem
operations), but I don't think this would cause a warning if the argument
is fixed.

Then there is the question of why in the world you would have an MMIO
register contain a kernel pointer, but that is more a driver design question
than something that causes a warning.

Arnd

\
 
 \ /
  Last update: 2020-08-02 12:49    [W:0.040 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site