Messages in this thread | | | From | Era Mayflower <> | Date | Wed, 19 Aug 2020 13:03:37 +0000 | Subject | Re: [PATCH] macsec: Support 32bit PN netlink attribute for XPN links |
| |
On Wed, Jun 24, 2020 at 10:23 AM Era Mayflower <mayflowerera@gmail.com> wrote: > > On Wed, Jun 17, 2020 at 1:32 AM Era Mayflower <mayflowerera@gmail.com> wrote: > > > > On Wed, Jun 17, 2020 at 10:02 AM Era Mayflower <mayflowerera@gmail.com> wrote: > > > > > > On Tue, Jun 16, 2020 at 1:23 AM David Miller <davem@davemloft.net> wrote: > > > > > > > > From: Era Mayflower <mayflowerera@gmail.com> > > > > Date: Tue, 16 Jun 2020 00:41:14 +0900 > > > > > > > > > + if (tb_sa[MACSEC_SA_ATTR_PN]) { > > > > > > > > validate_add_rxsa() requires that MACSET_SA_ATTR_PN be non-NULL, so > > > > you don't need to add this check here. > > > > > > > > > > validate_add_rxsa() did not originally contain that requirement. > > > It does exist in validate_add_txsa(), which means that providing a PN > > > is necessary only when creating TXSA. > > > When creating an RXSA without providing a PN it will be set to 1 > > > (init_rx_sa+15). > > > This is the original behavior which of course can be changed. > > > > > > - Era. > > > > Sorry for the time issues, just noticed I sent the previous mail with > > future time. > > Fixed it permanently on my computer. > > Hello, is there any news? > > - Era.
This patch is important to help projects like iproute2 use XPN macsec links. Please let me know if there is anything I need to fix.
- Era.
| |