Messages in this thread | | | Date | Thu, 20 Aug 2020 10:15:31 +0800 | From | Wei Yang <> | Subject | Re: [PATCH 1/2] mm/mmap: rename __vma_unlink_common() to __vma_unlink() |
| |
On Wed, Aug 19, 2020 at 01:12:10PM -0700, Andrew Morton wrote: >On Mon, 10 Aug 2020 07:20:56 +0800 Wei Yang <richard.weiyang@linux.alibaba.com> wrote: > >> __vma_unlink_common() and __vma_unlink() are counterparts. Since there is > >I assume you meant "__vma_link()" here? >
Oops, my fault. You are right.
Do you prefer a v2, or you would like to fix it online?
>> not function named __vma_unlink(), let's rename it to __vma_unlink() to >> make the code more self-explain and easy for audience to understand. >> >> Otherwise we may expect there are several variants of vma_unlink and >> __vma_unlink_common() is used by them.
-- Wei Yang Help you, Help me
| |