Messages in this thread | | | Date | Tue, 18 Aug 2020 16:28:20 +0200 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH v3 00/44] SPMI patches needed by Hikey 970 |
| |
Em Tue, 18 Aug 2020 16:17:50 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> escreveu:
> On Mon, Aug 17, 2020 at 09:10:19AM +0200, Mauro Carvalho Chehab wrote: > > Hi Greg, > > > > This patch series is part of a work I'm doing in order to be able to support > > a HiKey 970 board that I recently got on my hands. > > With this applied, I get the following build error: > ERROR: modpost: "__spmi_driver_register" [drivers/staging/hikey9xx/hi6421-spmi-pmic.ko] undefined! > ERROR: modpost: "spmi_ext_register_writel" [drivers/staging/hikey9xx/hi6421-spmi-pmic.ko] undefined! > ERROR: modpost: "spmi_ext_register_readl" [drivers/staging/hikey9xx/hi6421-spmi-pmic.ko] undefined! > ERROR: modpost: "spmi_controller_add" [drivers/staging/hikey9xx/hisi-spmi-controller.ko] undefined! > ERROR: modpost: "spmi_controller_alloc" [drivers/staging/hikey9xx/hisi-spmi-controller.ko] undefined! > ERROR: modpost: "spmi_controller_remove" [drivers/staging/hikey9xx/hisi-spmi-controller.ko] undefined! > > > I'll take this in my testing tree for now, can you send a follow-on > patch to fix this?
Surely. That's because it got moved from drivers/spmi/Kconfig. The Kconfig var was inside a:
if SPMI ... endif
This driver should "depends on SPMI". I'll send you a patch in a few.
Thanks, Mauro
| |