Messages in this thread Patch in this message | | | From | Greg Kroah-Hartman <> | Subject | [PATCH 4/7] media: mtk-vpu: no need to check return value of debugfs_create functions | Date | Tue, 18 Aug 2020 15:36:05 +0200 |
| |
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc: Minghsiu Tsai <minghsiu.tsai@mediatek.com> Cc: Houlong Wei <houlong.wei@mediatek.com> Cc: Andrew-CT Chen <andrew-ct.chen@mediatek.com> Cc: Tiffany Lin <tiffany.lin@mediatek.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Matthias Brugger <matthias.bgg@gmail.com> Cc: linux-media@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/media/platform/mtk-vpu/mtk_vpu.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c b/drivers/media/platform/mtk-vpu/mtk_vpu.c index d30c08983f56..36cb9b6131f7 100644 --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c @@ -849,10 +849,6 @@ static int mtk_vpu_probe(struct platform_device *pdev) #ifdef CONFIG_DEBUG_FS vpu_debugfs = debugfs_create_file("mtk_vpu", S_IRUGO, NULL, (void *)dev, &vpu_debug_fops); - if (!vpu_debugfs) { - ret = -ENOMEM; - goto cleanup_ipi; - } #endif /* Set PTCM to 96K and DTCM to 32K */ @@ -910,7 +906,6 @@ static int mtk_vpu_probe(struct platform_device *pdev) of_reserved_mem_device_release(dev); #ifdef CONFIG_DEBUG_FS debugfs_remove(vpu_debugfs); -cleanup_ipi: #endif memset(vpu->ipi_desc, 0, sizeof(struct vpu_ipi_desc) * IPI_MAX); vpu_mutex_destroy: -- 2.28.0
| |