Messages in this thread | | | Date | Tue, 18 Aug 2020 12:51:27 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH drm/hisilicon 0/4] Use drv_err instead of DRM_ERROR in hibmc driver |
| |
On Tue, Aug 18, 2020 at 02:51:40PM +0800, Tian Tao wrote: > patch #1 is using the drv_err instead of DRM_ERROR in hibmc_ttm.c > patch #2 is using the drv_err instead of DRM_ERROR in hibmc_drm_vdac.c > patch #3 is using the drv_err and drm_dbg_atomic instead of DRM_ERROR > and DRM_DEBUG_ATOMIC in hibmc_drm_de.c > patch #4 is using the drv_err and drm_warn instead of DRM_ERROR and > DRM_WARN in hibmc_drm_drv.c > > Tian Tao (4): > drm/hisilicon: Use drv_err instead of DRM_ERROR in hibmc_ttm > drm/hisilicon: Use drv_err instead of DRM_ERROR in hibmc_drm_vdac > drm/hisilicon: Use drv_err instead of DRM_ERROR in hibmc_drm_de > drm/hisilicon: Use drv_err instead of DRM_ERROR in hibmc_drm_drv
Hi Tian.
Code looks fine, but subjects says "drv_err", where code uses "drm_err". This confused me, mind fixing the $subject before applying
Sam
> > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 14 +++++++------- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 24 ++++++++++++------------ > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 4 ++-- > drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 2 +- > 4 files changed, 22 insertions(+), 22 deletions(-) > > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
| |