lkml.org 
[lkml]   [2020]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 13/17] file: Remove get_files_struct
    On Mon, Aug 17, 2020 at 05:04:21PM -0500, Eric W. Biederman wrote:
    > When discussing[1] exec and posix file locks it was realized that none
    > of the callers of get_files_struct fundamentally needed to call
    > get_files_struct, and that by switching them to helper functions
    > instead it will both simplify their code and remove unnecessary
    > increments of files_struct.count. Those unnecessary increments can
    > result in exec unnecessarily unsharing files_struct which breaking
    > posix locks, and it can result in fget_light having to fallback to
    > fget reducing system performance.
    >
    > Now that get_files_struct has no more users and can not cause the
    > problems for posix file locking and fget_light remove get_files_struct
    > so that it does not gain any new users.
    >
    > [1] https://lkml.kernel.org/r/20180915160423.GA31461@redhat.com
    > Suggested-by: Oleg Nesterov <oleg@redhat.com>
    > Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
    > ---

    Acked-by: Christian Brauner <christian.brauner@ubuntu.com>

    \
     
     \ /
      Last update: 2020-08-18 12:40    [W:5.253 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site