lkml.org 
[lkml]   [2020]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1] arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node
From
Date
Quoting Tanmay Shah (2020-08-17 15:45:27)
> This node defines alternate DP HPD functionality of GPIO.
>
> Signed-off-by: Tanmay Shah <tanmay@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index bf2f2bb1aa79..9f97cf5dd9ab 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1457,6 +1457,20 @@ pinconf-sd-cd {
> drive-strength = <2>;
> };
> };
> +
> + dp_hot_plug_det: dp-hot-plug-det {
> + pinmux {
> + pins = "gpio117";
> + function = "dp_hot";
> + };
> +
> + config {

The node name is usualy called pinconf. Please use that.

> + pins = "gpio117";
> + bias-disable;
> + input-enable;
> + drive-strength = <2>;

My understanding is that drive-strength doesn't do anything when the pin
is input. So this line should be removed.

> + };
> + };
> };
>
> gpu: gpu@5000000 {
>

\
 
 \ /
  Last update: 2020-08-18 00:51    [W:0.025 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site