lkml.org 
[lkml]   [2020]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] net: qrtr: fix usage of idr in port assignment to socket
From
From: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Date: Mon, 17 Aug 2020 15:54:48 +0000

> From: Necip Fazil Yildiran <necip@google.com>
>
> Passing large uint32 sockaddr_qrtr.port numbers for port allocation
> triggers a warning within idr_alloc() since the port number is cast
> to int, and thus interpreted as a negative number. This leads to
> the rejection of such valid port numbers in qrtr_port_assign() as
> idr_alloc() fails.
>
> To avoid the problem, switch to idr_alloc_u32() instead.
>
> Fixes: bdabad3e363d ("net: Add Qualcomm IPC router")
> Reported-by: syzbot+f31428628ef672716ea8@syzkaller.appspotmail.com
> Signed-off-by: Necip Fazil Yildiran <necip@google.com>
> Reviewed-by: Dmitry Vyukov <dvyukov@google.com>

Applied and queued up for -stable, thank you.

\
 
 \ /
  Last update: 2020-08-18 00:01    [W:0.029 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site