lkml.org 
[lkml]   [2020]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 269/464] mt76: mt7615: fix potential memory leak in mcu message handler
    Date
    From: Sean Wang <sean.wang@mediatek.com>

    [ Upstream commit 9248c08c3fc4ef816c82aa49d01123f4746d349f ]

    Fix potential memory leak in mcu message handler on error condition.

    Fixes: 0e6a29e477f3 ("mt76: mt7615: add support to read temperature from mcu")
    Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
    Signed-off-by: Sean Wang <sean.wang@mediatek.com>
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
    index 6e869b8c5e266..d8c52ffcf0ecb 100644
    --- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
    +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
    @@ -180,8 +180,10 @@ mt7615_mcu_parse_response(struct mt7615_dev *dev, int cmd,
    struct mt7615_mcu_rxd *rxd = (struct mt7615_mcu_rxd *)skb->data;
    int ret = 0;

    - if (seq != rxd->seq)
    - return -EAGAIN;
    + if (seq != rxd->seq) {
    + ret = -EAGAIN;
    + goto out;
    + }

    switch (cmd) {
    case MCU_CMD_PATCH_SEM_CONTROL:
    @@ -208,6 +210,7 @@ mt7615_mcu_parse_response(struct mt7615_dev *dev, int cmd,
    default:
    break;
    }
    +out:
    dev_kfree_skb(skb);

    return ret;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-08-17 21:34    [W:5.501 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site