lkml.org 
[lkml]   [2020]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] WIP: ASoC: mediatek: mt6359: add codec driver
On Fri, Aug 14, 2020 at 06:45:53PM +0800, Jiaxin Yu wrote:

This looks mostly good, a couple of very small things:

> + ret = regulator_enable(priv->avdd_reg);
> + if (ret) {
> + dev_err(&pdev->dev, "%s(), failed to enable regulator!\n",
> + __func__);
> + return ret;
> + }

You need a remove() function to undo this enable.

> + dev_info(&pdev->dev, "%s(), dev name %s\n",
> + __func__, dev_name(&pdev->dev));

This isn't really adding anything, just remove it - it's not reading
info from the hardware or anything.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-08-14 18:02    [W:0.064 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site