Messages in this thread | | | Subject | Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused | From | Christian Lamparter <> | Date | Fri, 14 Aug 2020 17:14:31 +0200 |
| |
On 2020-08-14 13:39, Lee Jones wrote: > 'ar9170_qmap' is used in some source files which include carl9170.h, > but not all of them. Mark it as __maybe_unused to show that this is > not only okay, it's expected. > > Fixes the following W=1 kernel build warning(s)
Is this W=1 really a "must" requirement? I find it strange having __maybe_unused in header files as this "suggests" that the definition is redundant.
> from drivers/net/wireless/ath/carl9170/carl9170.h:57, > In file included from drivers/net/wireless/ath/carl9170/carl9170.h:57, > drivers/net/wireless/ath/carl9170/carl9170.h:71:17: warning: ‘ar9170_qmap’ defined but not used [-Wunused-const-variable=] >
> > Cc: Christian Lamparter <chunkeey@googlemail.com> > Cc: Kalle Valo <kvalo@codeaurora.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Johannes Berg <johannes@sipsolutions.net> > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/net/wireless/ath/carl9170/carl9170.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/carl9170/carl9170.h b/drivers/net/wireless/ath/carl9170/carl9170.h > index 237d0cda1bcb0..9d86253081bce 100644 > --- a/drivers/net/wireless/ath/carl9170/carl9170.h > +++ b/drivers/net/wireless/ath/carl9170/carl9170.h > @@ -68,7 +68,7 @@ > > #define PAYLOAD_MAX (CARL9170_MAX_CMD_LEN / 4 - 1) > > -static const u8 ar9170_qmap[__AR9170_NUM_TXQ] = { 3, 2, 1, 0 }; > +static const u8 __maybe_unused ar9170_qmap[__AR9170_NUM_TXQ] = { 3, 2, 1, 0 }; > > #define CARL9170_MAX_RX_BUFFER_SIZE 8192 > >
| |