Messages in this thread | | | From | Valentin Schneider <> | Subject | Re: [PATCH v5 02/17] ARM: Revert back to default scheduler topology. | Date | Thu, 13 Aug 2020 23:27:05 +0100 |
| |
On 13/08/20 20:16, Ingo Molnar wrote: > * Valentin Schneider <valentin.schneider@arm.com> wrote: > >> The ARM-specific GMC level is meant to be built using the thread sibling >> mask, but no devicetree in arch/arm/boot/dts uses the 'thread' cpu-map >> binding. With SD_SHARE_POWERDOMAIN gone, this topology level can be >> removed, at which point ARM no longer benefits from having a custom defined >> topology table. >> >> Delete the GMC topology level by making ARM use the default scheduler >> topology table. This essentially reverts commit >> >> fb2aa85564f4 ("sched, ARM: Create a dedicated scheduler topology table") >> >> Cc: Russell King <linux@armlinux.org.uk> >> Suggested-by: Dietmar Eggemann <dietmar.eggemann@arm.com> >> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com> >> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com> > > Minor changelog nit, it's helpful to add this final sentence: > > No change in functionality is expected. > > ( If indeed no change in functionality is expected. ;-) >
Right, that's indeed the case here given the GMC domain would always be degenerated anyway.
> Thanks, > > Ingo
| |