lkml.org 
[lkml]   [2020]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v12 04/13] iommu: Add a domain attribute to get/set a pagetable configuration
    On Mon, Aug 10, 2020 at 04:26:48PM -0600, Jordan Crouse wrote:
    > Add domain attribute DOMAIN_ATTR_PGTABLE_CFG. This will be used by
    > arm-smmu to share the current pagetable configuration with the
    > leaf driver and to allow the leaf driver to set up a new pagetable
    > configuration under certain circumstances.
    >
    > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
    > ---
    >
    > include/linux/iommu.h | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/include/linux/iommu.h b/include/linux/iommu.h
    > index fee209efb756..995ab8c47ef2 100644
    > --- a/include/linux/iommu.h
    > +++ b/include/linux/iommu.h
    > @@ -118,6 +118,7 @@ enum iommu_attr {
    > DOMAIN_ATTR_FSL_PAMUV1,
    > DOMAIN_ATTR_NESTING, /* two stages of translation */
    > DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE,
    > + DOMAIN_ATTR_PGTABLE_CFG,
    > DOMAIN_ATTR_MAX,
    > };

    Nobody other than the adreno gpu uses this, so can we avoid exposing it
    in the IOMMU API, please? Given that you have a reference to the adreno
    GPU device in the SMMU implementation code thanks to .alloc_context_bank(),
    can you squirrel some function pointers away in the driver data (i.e. with
    dev_set_drvdata()) instead?

    Will

    \
     
     \ /
      Last update: 2020-08-13 15:14    [W:4.146 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site