Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff | Date | Thu, 13 Aug 2020 09:33:31 +0200 |
| |
Jiafei Pan <Jiafei.Pan@nxp.com> writes: > __raise_softirq_irqoff will update per-CPU mask of pending softirqs,
Please write __raise_softirq_irqoff() so it's clear that this is about a function.
> void __raise_softirq_irqoff(unsigned int nr) > { > + /* This function can only be called in irq disabled context, > + * otherwise or_softirq_pending will be interrupted by hardware > + * interrupt, so that there will be unexpected issue. > + */ > + WARN_ON_ONCE(!irqs_disabled());
Please use lockdep_assert_irqs_disabled() instead.
Thanks,
tglx
| |