Messages in this thread | | | Date | Wed, 12 Aug 2020 14:09:09 -0700 | From | Sami Tolvanen <> | Subject | Re: [PATCH v2] RAS/CEC: Fix cec_init prototype |
| |
Hi Luca,
On Wed, Aug 05, 2020 at 11:57:08AM +0200, Luca Stefani wrote: > * late_initcall expects a function that returns an integer > -> Update the function signature to match. > > Fixes: 9554bfe403nd ("x86/mce: Convert the CEC to use the MCE notifier") > Signed-off-by: Luca Stefani <luca.stefani.ge1@gmail.com>
Thank you for fixing this!
[Note that this v2 email never landed in my inbox, perhaps Gmail filtered it out due to a missing To: line?]
> --- > drivers/ras/cec.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c > index 569d9ad2c594..6939aa5b3dc7 100644 > --- a/drivers/ras/cec.c > +++ b/drivers/ras/cec.c > @@ -553,20 +553,20 @@ static struct notifier_block cec_nb = { > .priority = MCE_PRIO_CEC, > }; > > -static void __init cec_init(void) > +static int __init cec_init(void) > { > if (ce_arr.disabled) > - return; > + return -ENODEV; > > ce_arr.array = (void *)get_zeroed_page(GFP_KERNEL); > if (!ce_arr.array) { > pr_err("Error allocating CE array page!\n"); > - return; > + return -ENOMEM; > } > > if (create_debugfs_nodes()) { > free_page((unsigned long)ce_arr.array); > - return; > + return -ENOMEM; > } > > INIT_DELAYED_WORK(&cec_work, cec_work_fn); > @@ -575,6 +575,7 @@ static void __init cec_init(void) > mce_register_decode_chain(&cec_nb); > > pr_info("Correctable Errors collector initialized.\n"); > + return 0; > } > late_initcall(cec_init);
The type mismatch broke allyesconfig in my test tree and your patch fixes the issue. Please feel free to add:
Reviewed-and-tested-by: Sami Tolvanen <samitolvanen@google.com>
Sami
| |