lkml.org 
[lkml]   [2020]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 16/67] Staging: rtl8188eu: rtw_mlme: Fix uninitialized variable authmode
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    commit 11536442a3b4e1de6890ea5e805908debb74f94a upstream.

    The variable authmode can be uninitialized. The danger would be if
    it equals to _WPA_IE_ID_ (0xdd) or _WPA2_IE_ID_ (0x33). We can avoid
    this by setting it to zero instead. This is the approach that was
    used in the rtl8723bs driver.

    Fixes: 7b464c9fa5cc ("staging: r8188eu: Add files for new driver - part 4")
    Co-developed-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Cc: stable <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20200728072153.9202-1-dinghao.liu@zju.edu.cn
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/rtl8188eu/core/rtw_mlme.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
    +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c
    @@ -1729,9 +1729,11 @@ int rtw_restruct_sec_ie(struct adapter *
    if ((ndisauthmode == Ndis802_11AuthModeWPA) ||
    (ndisauthmode == Ndis802_11AuthModeWPAPSK))
    authmode = _WPA_IE_ID_;
    - if ((ndisauthmode == Ndis802_11AuthModeWPA2) ||
    + else if ((ndisauthmode == Ndis802_11AuthModeWPA2) ||
    (ndisauthmode == Ndis802_11AuthModeWPA2PSK))
    authmode = _WPA2_IE_ID_;
    + else
    + authmode = 0x0;

    if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS)) {
    memcpy(out_ie+ielength, psecuritypriv->wps_ie, psecuritypriv->wps_ie_len);

    \
     
     \ /
      Last update: 2020-08-10 17:38    [W:3.229 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site