Messages in this thread | | | Date | Mon, 10 Aug 2020 16:00:35 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH] usb: gadget: tegra-xudc: Avoid GFP_ATOMIC where it is not needed |
| |
On Sun, Aug 09, 2020 at 09:29:48AM +0200, Christophe JAILLET wrote: > There is no need to use GFP_ATOMIC here. It is a probe function, no > spinlock is taken. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/usb/gadget/udc/tegra-xudc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Looks good to me. I can't think of any reason why this would have to be an atomic allocation. Nagarjuna, please shout if this is really needed, otherwise:
Acked-by: Thierry Reding <treding@nvidia.com> [unhandled content-type:application/pgp-signature] | |