Messages in this thread | | | From | Kamalesh Babulal <> | Subject | Re: [PATCH] tools/objtool: Fix unnecessary jumps | Date | Mon, 10 Aug 2020 18:27:01 +0530 |
| |
On 10/08/20 9:36 am, Youling Tang wrote: > There is no need to jump to the "out" tag when "ret < 0", just return > directly to "ret". > > Signed-off-by: Youling Tang <tangyouling@loongson.cn> > --- > tools/objtool/check.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c > index e034a8f..94b166d 100644 > --- a/tools/objtool/check.c > +++ b/tools/objtool/check.c
[snip]
> > if (file.elf->changed) { > ret = elf_write(file.elf); > if (ret < 0) > - goto out; > + return ret; > } > > out:
the out label code is no more required with this change, so remove it and return 0 for warnings for now. Previously cleanup() function was called under the out label for both fatal errors (ret < 0) and warnings. Now that cleanup() function is removed, the out label is no longer required.
-- Kamalesh
| |