Messages in this thread | | | Date | Mon, 10 Aug 2020 15:14:13 +0530 | From | Vaibhav Gupta <> | Subject | Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management |
| |
> > > -static int gxfb_suspend(struct pci_dev *pdev, pm_message_t state) > > > +static int __maybe_unused gxfb_suspend(struct device *dev) > > > { > > > - struct fb_info *info = pci_get_drvdata(pdev); > > > + struct fb_info *info = dev_get_drvdata(dev); > > I do not see any dev_set_drvdata() so I guess we get a NULL pointer > > here which is not intended. > > Adding a dev_set_data() to gxfb_probe() would do the trick. > > > gxfb_probe() invokes pci_set_drvdata(pdev, info) which in turn calls > dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant. > s/dev_get_drvdata/dev_set_drvdata
Thanks Vaibhav Gupta
| |