lkml.org 
[lkml]   [2020]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] dt-bindings: interconnect: Add generic qcom bindings
From
Date
On 7/9/2020 8:35 AM, Matthias Kaehlcke wrote:
> On Mon, Jun 22, 2020 at 09:05:14PM -0700, Mike Tipton wrote:
>> Add generic qcom interconnect bindings that are common across platforms. In
>> particular, these include QCOM_ICC_TAG_* macros that clients can use when
>> calling icc_set_tag().
>>
>> Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
>> ---
>> include/dt-bindings/interconnect/qcom,icc.h | 26 +++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>> create mode 100644 include/dt-bindings/interconnect/qcom,icc.h
>>
>> diff --git a/include/dt-bindings/interconnect/qcom,icc.h b/include/dt-bindings/interconnect/qcom,icc.h
>> new file mode 100644
>> index 000000000000..cd34f36daaaa
>> --- /dev/null
>> +++ b/include/dt-bindings/interconnect/qcom,icc.h
>> @@ -0,0 +1,26 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +/*
>> + * Copyright (c) 2020, The Linux Foundation. All rights reserved.
>> + */
>> +
>> +#ifndef __DT_BINDINGS_INTERCONNECT_QCOM_ICC_H
>> +#define __DT_BINDINGS_INTERCONNECT_QCOM_ICC_H
>> +
>> +/*
>> + * The AMC bucket denotes constraints that are applied to hardware when
>> + * icc_set_bw() completes, whereas the WAKE and SLEEP constraints are applied
>> + * when the execution environment transitions between active and low power mode.
>> + */
>> +#define QCOM_ICC_BUCKET_AMC 0
>> +#define QCOM_ICC_BUCKET_WAKE 1
>> +#define QCOM_ICC_BUCKET_SLEEP 2
>> +#define QCOM_ICC_NUM_BUCKETS 3
>> +
>> +#define QCOM_ICC_TAG_AMC (1 << QCOM_ICC_BUCKET_AMC)
>> +#define QCOM_ICC_TAG_WAKE (1 << QCOM_ICC_BUCKET_WAKE)
>> +#define QCOM_ICC_TAG_SLEEP (1 << QCOM_ICC_BUCKET_SLEEP)
>> +#define QCOM_ICC_TAG_ACTIVE_ONLY (QCOM_ICC_TAG_AMC | QCOM_ICC_TAG_WAKE)
>> +#define QCOM_ICC_TAG_ALWAYS (QCOM_ICC_TAG_AMC | QCOM_ICC_TAG_WAKE |\
>> + QCOM_ICC_TAG_SLEEP)
>> +
>> +#endif
>
> Would it make sense to squash the two patches of this series into a
> single patch? This would make it more evident that this was moved
> from drivers/interconnect/qcom/icc-rpmh.h and avoid duplicate
> definitions if only this patch was applied.

Makes sense to me. I'm going to have to move this to my other patch
series anyway, so I can squash these two and include it in v2 of
"interconnect: qcom: Misc bcm-voter changes and fixes".

\
 
 \ /
  Last update: 2020-07-09 21:46    [W:0.065 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site