lkml.org 
[lkml]   [2020]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning
On Thu, Jul 9, 2020 at 9:11 AM Ethan Edwards
<ethancarteredwards@gmail.com> wrote:
>
> `sizeof buf` changed to `sizeof(buf)`
>
> Signed-off-by: Ethan Edwards <ethancarteredwards@gmail.com>
> ---
> security/selinux/ss/conditional.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Why are you reposting this when I applied your original patch last week?

https://lore.kernel.org/selinux/CAHC9VhSakA7V99+tkvLLZHohiupWmjSFxSZLWZT4-Gwr5Cc-XA@mail.gmail.com

> diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c
> index 0cc7cdd58465..90a2f5927e55 100644
> --- a/security/selinux/ss/conditional.c
> +++ b/security/selinux/ss/conditional.c
> @@ -215,7 +215,7 @@ int cond_read_bool(struct policydb *p, struct hashtab *h, void *fp)
> if (!booldatum)
> return -ENOMEM;
>
> - rc = next_entry(buf, fp, sizeof buf);
> + rc = next_entry(buf, fp, sizeof(buf));
> if (rc)
> goto err;
>
> @@ -416,7 +416,7 @@ int cond_read_list(struct policydb *p, void *fp)
> u32 i, len;
> int rc;
>
> - rc = next_entry(buf, fp, sizeof buf);
> + rc = next_entry(buf, fp, sizeof(buf));
> if (rc)
> return rc;
>
> --
> 2.27.0
>


--
paul moore
www.paul-moore.com

\
 
 \ /
  Last update: 2020-07-09 20:11    [W:2.151 / U:0.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site