lkml.org 
[lkml]   [2020]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/24] scsi: ipr: Fix struct packed-not-aligned issues
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/scsi/ipr.h:1687:1: warning: alignment 1 of ‘struct ipr_dump_location_entry’ is less than 4 [-Wpacked-not-aligned]
    1687 | }__attribute__((packed));
    | ^
    drivers/scsi/ipr.h:1711:1: warning: alignment 1 of ‘struct ipr_driver_dump’ is less than 4 [-Wpacked-not-aligned]
    1711 | }__attribute__((packed));
    | ^

    Cc: Brian King <brking@us.ibm.com>
    Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/scsi/ipr.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/scsi/ipr.h b/drivers/scsi/ipr.h
    index 9a0d3d7293206..783ee03ad9ea2 100644
    --- a/drivers/scsi/ipr.h
    +++ b/drivers/scsi/ipr.h
    @@ -1684,7 +1684,7 @@ struct ipr_dump_entry_header {
    struct ipr_dump_location_entry {
    struct ipr_dump_entry_header hdr;
    u8 location[20];
    -}__attribute__((packed));
    +}__attribute__((packed, aligned (4)));

    struct ipr_dump_trace_entry {
    struct ipr_dump_entry_header hdr;
    @@ -1708,7 +1708,7 @@ struct ipr_driver_dump {
    struct ipr_dump_location_entry location_entry;
    struct ipr_dump_ioa_type_entry ioa_type_entry;
    struct ipr_dump_trace_entry trace_entry;
    -}__attribute__((packed));
    +}__attribute__((packed, aligned (4)));

    struct ipr_ioa_dump {
    struct ipr_dump_entry_header hdr;
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-07-09 19:47    [W:4.044 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site