Messages in this thread | | | Subject | Re: [PATCH] scsi: virtio_scsi: remove unnecessary condition check | From | Paolo Bonzini <> | Date | Thu, 9 Jul 2020 17:26:27 +0200 |
| |
On 09/07/20 16:46, Xianting Tian wrote: > kmem_cache_destroy can correctly handle null pointer parameter, > so there is no need to check if the parameter is null before > calling kmem_cache_destroy. > > Signed-off-by: Xianting Tian <xianting_tian@126.com> > --- > drivers/scsi/virtio_scsi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c > index bfec84a..5bc288f 100644 > --- a/drivers/scsi/virtio_scsi.c > +++ b/drivers/scsi/virtio_scsi.c > @@ -1007,10 +1007,8 @@ static int __init init(void) > mempool_destroy(virtscsi_cmd_pool); > virtscsi_cmd_pool = NULL; > } > - if (virtscsi_cmd_cache) { > - kmem_cache_destroy(virtscsi_cmd_cache); > - virtscsi_cmd_cache = NULL; > - } > + kmem_cache_destroy(virtscsi_cmd_cache); > + virtscsi_cmd_cache = NULL; > return ret; > } > >
Acked-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
| |