lkml.org 
[lkml]   [2020]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 7/7] drivers: staging: audio: Fix the missing header file for helper file
    Date
    This patch fixes the warning reported for missing prototypes due to
    missing header file. Also, it includes changes to remove
    unused_but_set_variables.

    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
    ---
    drivers/staging/greybus/audio_helper.c | 1 +
    drivers/staging/greybus/audio_topology.c | 8 ++++----
    2 files changed, 5 insertions(+), 4 deletions(-)

    diff --git a/drivers/staging/greybus/audio_helper.c b/drivers/staging/greybus/audio_helper.c
    index faaa39708118..8b100a71f02e 100644
    --- a/drivers/staging/greybus/audio_helper.c
    +++ b/drivers/staging/greybus/audio_helper.c
    @@ -7,6 +7,7 @@
    #include <sound/core.h>
    #include <sound/soc.h>
    #include <sound/soc-dapm.h>
    +#include "audio_helper.h"

    #define gbaudio_dapm_for_each_direction(dir) \
    for ((dir) = SND_SOC_DAPM_DIR_IN; (dir) <= SND_SOC_DAPM_DIR_OUT; \
    diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c
    index ad88d3127a60..2f9fdbdcd547 100644
    --- a/drivers/staging/greybus/audio_topology.c
    +++ b/drivers/staging/greybus/audio_topology.c
    @@ -28,14 +28,16 @@ static struct gbaudio_module_info *find_gb_module(
    struct gbaudio_codec_info *codec,
    char const *name)
    {
    - int dev_id, ret;
    + int dev_id;
    char begin[NAME_SIZE];
    struct gbaudio_module_info *module;

    if (!name)
    return NULL;

    - ret = sscanf(name, "%s %d", begin, &dev_id);
    + if (sscanf(name, "%s %d", begin, &dev_id) != 2)
    + return NULL;
    +
    dev_dbg(codec->dev, "%s:Find module#%d\n", __func__, dev_id);

    mutex_lock(&codec->lock);
    @@ -377,7 +379,6 @@ static int gbcodec_mixer_dapm_ctl_get(struct snd_kcontrol *kcontrol,
    struct snd_ctl_elem_value *ucontrol)
    {
    int ret;
    - struct gb_audio_ctl_elem_info *info;
    struct gbaudio_ctl_pvt *data;
    struct gb_audio_ctl_elem_value gbvalue;
    struct gbaudio_module_info *module;
    @@ -393,7 +394,6 @@ static int gbcodec_mixer_dapm_ctl_get(struct snd_kcontrol *kcontrol,
    return -EINVAL;

    data = (struct gbaudio_ctl_pvt *)kcontrol->private_value;
    - info = (struct gb_audio_ctl_elem_info *)data->info;
    bundle = to_gb_bundle(module->dev);

    if (data->vcount == 2)
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-07-09 12:28    [W:3.282 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site