lkml.org 
[lkml]   [2020]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] i3c: master: svc: Add Silvaco I3C master driver
Hi Miquel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v5.8-rc4 next-20200709]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Miquel-Raynal/dt-bindings-Add-vendor-prefix-for-Silvaco/20200709-160518
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/i3c/master/svc-i3c-master.c:189:6: warning: no previous prototype for 'svc_i3c_master_enable_interrupts' [-Wmissing-prototypes]
189 | void svc_i3c_master_enable_interrupts(struct svc_i3c_master *master, u32 mask)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/i3c/master/svc-i3c-master.c:194:6: warning: no previous prototype for 'svc_i3c_master_disable_interrupts' [-Wmissing-prototypes]
194 | void svc_i3c_master_disable_interrupts(struct svc_i3c_master *master)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/i3c/master/svc-i3c-master.c: In function 'svc_i3c_master_bus_init':
drivers/i3c/master/svc-i3c-master.c:456:20: warning: comparison is always false due to limited range of data type [-Wtype-limits]
456 | if (info.dyn_addr < 0)
| ^
drivers/i3c/master/svc-i3c-master.c: In function 'svc_i3c_master_do_daa_locked':
drivers/i3c/master/svc-i3c-master.c:691:21: warning: comparison is always false due to limited range of data type [-Wtype-limits]
691 | if (addrs[dev_nb] < 0)
| ^

vim +/svc_i3c_master_enable_interrupts +189 drivers/i3c/master/svc-i3c-master.c

188
> 189 void svc_i3c_master_enable_interrupts(struct svc_i3c_master *master, u32 mask)
190 {
191 writel(mask, master->regs + SVC_I3C_MINTSET);
192 }
193
> 194 void svc_i3c_master_disable_interrupts(struct svc_i3c_master *master)
195 {
196 u32 mask = readl(master->regs + SVC_I3C_MINTSET);
197
198 writel(mask, master->regs + SVC_I3C_MINTCLR);
199 }
200

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2020-07-09 12:10    [W:0.117 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site