Messages in this thread | | | Subject | Re: [PATCH] drm/amd/display: add dmcub check on RENOIR | From | "Kazlauskas, Nicholas" <> | Date | Wed, 8 Jul 2020 10:30:52 -0400 |
| |
Looks good to me.
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Regards, Nicholas Kazlauskas
On 2020-07-08 10:15 a.m., Deucher, Alexander wrote: > [AMD Public Use] > > > [AMD Public Use] > > > Acked-by: Alex Deucher <alexander.deucher@amd.com> > ------------------------------------------------------------------------ > *From:* Aaron Ma <aaron.ma@canonical.com> > *Sent:* Wednesday, July 8, 2020 4:16 AM > *To:* Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) > <Sunpeng.Li@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; > Koenig, Christian <Christian.Koenig@amd.com>; airlied@linux.ie > <airlied@linux.ie>; daniel@ffwll.ch <daniel@ffwll.ch>; > amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; > dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; > linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; > mapengyu@gmail.com <mapengyu@gmail.com>; aaron.ma@canonical.com > <aaron.ma@canonical.com> > *Subject:* [PATCH] drm/amd/display: add dmcub check on RENOIR > RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram, > it breaks backlight control. > > Bug: > https://bugzilla.kernel.org/show_bug.cgi?id=208277 > <https://bugzilla.kernel.org/show_bug.cgi?id=208277> > Signed-off-by: Aaron Ma <aaron.ma@canonical.com> > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index 10ac8076d4f2..db5e0bb0d935 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -1358,7 +1358,7 @@ static int dm_late_init(void *handle) > struct dmcu *dmcu = NULL; > bool ret; > > - if (!adev->dm.fw_dmcu) > + if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw) > return detect_mst_link_for_all_connectors(adev->ddev); > > dmcu = adev->dm.dc->res_pool->dmcu; > -- > 2.25.1 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >
| |