lkml.org 
[lkml]   [2020]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 18/30] scsi: bnx2fc: bnx2fc_tgt: Demote obvious misuse of kerneldoc to standard comment blocks
    Date
    No attempt has been made to document either of the demoted functions here.

    Fixes the following W=1 kernel build warning(s):

    drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member 'lport' not described in 'bnx2fc_rport_event_handler'
    drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member 'rdata' not described in 'bnx2fc_rport_event_handler'
    drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member 'event' not described in 'bnx2fc_rport_event_handler'
    drivers/scsi/bnx2fc/bnx2fc_tgt.c:665: warning: Function parameter or member 'hba' not described in 'bnx2fc_alloc_session_resc'
    drivers/scsi/bnx2fc/bnx2fc_tgt.c:665: warning: Function parameter or member 'tgt' not described in 'bnx2fc_alloc_session_resc'

    Cc: QLogic-Storage-Upstream@qlogic.com
    Cc: Prakash Gollapudi <bprakash@broadcom.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/scsi/bnx2fc/bnx2fc_tgt.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/drivers/scsi/bnx2fc/bnx2fc_tgt.c b/drivers/scsi/bnx2fc/bnx2fc_tgt.c
    index 50384b4a817c8..a3e2a38aabf2f 100644
    --- a/drivers/scsi/bnx2fc/bnx2fc_tgt.c
    +++ b/drivers/scsi/bnx2fc/bnx2fc_tgt.c
    @@ -431,7 +431,7 @@ static int bnx2fc_init_tgt(struct bnx2fc_rport *tgt,
    return 0;
    }

    -/**
    +/*
    * This event_callback is called after successful completion of libfc
    * initiated target login. bnx2fc can proceed with initiating the session
    * establishment.
    @@ -656,9 +656,8 @@ static void bnx2fc_free_conn_id(struct bnx2fc_hba *hba, u32 conn_id)
    spin_unlock_bh(&hba->hba_lock);
    }

    -/**
    - *bnx2fc_alloc_session_resc - Allocate qp resources for the session
    - *
    +/*
    + * bnx2fc_alloc_session_resc - Allocate qp resources for the session
    */
    static int bnx2fc_alloc_session_resc(struct bnx2fc_hba *hba,
    struct bnx2fc_rport *tgt)
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-07-08 14:04    [W:2.159 / U:0.904 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site