Messages in this thread | | | Date | Wed, 8 Jul 2020 13:28:25 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH] spi: use kthread_create_worker() helper |
| |
On Wed 2020-07-08 09:09:00, Marek Szyprowski wrote: > Since commit 4977caef05aa ("kthread: work could not be queued when worker > being destroyed")
This commit should disappear from linux-next soon. We did not expect that it would cause these warnings. We first want to fix the callers before we put it back.
> there is a warning when kworker is used without the > internal 'task' entry properly initialized. Fix this by using > a kthread_create_worker() helper instead of open-coding a kworker > initialization.
But the fix is great and makes sense on its own.
The use of kthread_create_worker() simplifies the code. It uses the kthread worker API the right way. It will eventually allow to remove the FIXME in kthread_worker_fn() and add more consistency checks.
I would use the above reasoning instead of the backtrace in the commit message. And feel free to use:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards, Petr Mladek
| |