lkml.org 
[lkml]   [2020]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 15/17] tools: gpio: fix spurious close warning in lsgpio
    Date
    Fix bogus close warning that occurs when opening the character device
    fails.

    Signed-off-by: Kent Gibson <warthog618@gmail.com>
    ---
    tools/gpio/lsgpio.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/tools/gpio/lsgpio.c b/tools/gpio/lsgpio.c
    index 8a71ad36f83b..b08d7a5e779b 100644
    --- a/tools/gpio/lsgpio.c
    +++ b/tools/gpio/lsgpio.c
    @@ -94,7 +94,7 @@ int list_device(const char *device_name)
    if (fd == -1) {
    ret = -errno;
    fprintf(stderr, "Failed to open %s\n", chrdev_name);
    - goto exit_close_error;
    + goto exit_free_name;
    }

    /* Inspect this GPIO chip */
    @@ -141,6 +141,7 @@ int list_device(const char *device_name)
    exit_close_error:
    if (close(fd) == -1)
    perror("Failed to close GPIO character device file");
    +exit_free_name:
    free(chrdev_name);
    return ret;
    }
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-07-08 06:21    [W:2.786 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site