lkml.org 
[lkml]   [2020]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 07/11] mm/gup: use a standard migration target allocation callback
On Tue, Jul 07, 2020 at 01:46:14PM +0200, Michal Hocko wrote:
> On Tue 07-07-20 16:44:45, Joonsoo Kim wrote:
> [...]
> > @@ -1551,9 +1552,12 @@ struct page *alloc_migration_target(struct page *page, unsigned long private)
> >
> > gfp_mask |= htlb_alloc_mask(h);
> > return alloc_huge_page_nodemask(h, nid, mtc->nmask,
> > - gfp_mask, false);
> > + gfp_mask, mtc->skip_cma);
> > }
> >
> > + if (mtc->skip_cma)
> > + flags = memalloc_nocma_save();
> > +
>
> As already mentioned in previous email this is a completely wrong usage
> of the scope API. The scope should be defined by the caller and this
> should be all transparent by the allocator layer.

Okay. Like as newly sent patch for 04/11, this patch will also be changed.

Thanks.

\
 
 \ /
  Last update: 2020-07-08 09:22    [W:0.180 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site