lkml.org 
[lkml]   [2020]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/2] fs: Remove kiocb->ki_complete
    From
    Date
    On 7/8/20 4:26 PM, Matthew Wilcox (Oracle) wrote:
    > +void unregister_kiocb_completion(int id)
    > +{
    > + ki_cmpls[id - 1] = NULL;
    > +}
    > +EXPORT_SYMBOL(unregister_kiocb_completion);

    This should have a limit check (<= 0 || > max).

    > void complete_kiocb(struct kiocb *iocb, long ret, long ret2)
    > {
    > - iocb->ki_complete(iocb, ret, ret2);
    > + unsigned int id = kiocb_completion_id(iocb);
    > +
    > + if (id > 0)
    > + ki_cmpls[id - 1](iocb, ret, ret2);
    > }

    I'd make id == 0 be a dummy funciton to avoid this branch.

    --
    Jens Axboe

    \
     
     \ /
      Last update: 2020-07-09 05:25    [W:4.228 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site