Messages in this thread | | | From | Justin He <> | Subject | RE: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory | Date | Thu, 9 Jul 2020 02:16:47 +0000 |
| |
Hi Matthew
> -----Original Message----- > From: Matthew Wilcox <willy@infradead.org> > Sent: Thursday, July 9, 2020 10:11 AM > To: Justin He <Justin.He@arm.com> > Cc: Catalin Marinas <Catalin.Marinas@arm.com>; Will Deacon > <will@kernel.org>; Tony Luck <tony.luck@intel.com>; Fenghua Yu > <fenghua.yu@intel.com>; Yoshinori Sato <ysato@users.sourceforge.jp>; Rich > Felker <dalias@libc.org>; Dave Hansen <dave.hansen@linux.intel.com>; Andy > Lutomirski <luto@kernel.org>; Peter Zijlstra <peterz@infradead.org>; > Thomas Gleixner <tglx@linutronix.de>; Ingo Molnar <mingo@redhat.com>; > Borislav Petkov <bp@alien8.de>; David Hildenbrand <david@redhat.com>; > x86@kernel.org; H. Peter Anvin <hpa@zytor.com>; Dan Williams > <dan.j.williams@intel.com>; Vishal Verma <vishal.l.verma@intel.com>; Dave > Jiang <dave.jiang@intel.com>; Andrew Morton <akpm@linux-foundation.org>; > Baoquan He <bhe@redhat.com>; Chuhong Yuan <hslester96@gmail.com>; Mike > Rapoport <rppt@linux.ibm.com>; Logan Gunthorpe <logang@deltatee.com>; > Masahiro Yamada <masahiroy@kernel.org>; Michal Hocko <mhocko@suse.com>; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux- > ia64@vger.kernel.org; linux-sh@vger.kernel.org; linux-nvdimm@lists.01.org; > linux-mm@kvack.org; Jonathan Cameron <Jonathan.Cameron@huawei.com>; Kaly > Xin <Kaly.Xin@arm.com> > Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in > arch specific directory > > On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > > After a general version of __weak memory_add_physaddr_to_nid implemented > > and exported , it is no use exporting twice in arch directory even if > > e,g, ia64/x86 have their specific version. > > > > This is to suppress the modpost warning: > > WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > > Previous export was in vmlinux > > It's bad form to introduce a warning and then send a follow-up patch to > fix the warning. Just fold this patch into patch 1/6. Thanks, will do
Cheers, Justin He
| |