Messages in this thread | | | Date | Thu, 9 Jul 2020 03:11:04 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory |
| |
On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > After a general version of __weak memory_add_physaddr_to_nid implemented > and exported , it is no use exporting twice in arch directory even if > e,g, ia64/x86 have their specific version. > > This is to suppress the modpost warning: > WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > Previous export was in vmlinux
It's bad form to introduce a warning and then send a follow-up patch to fix the warning. Just fold this patch into patch 1/6.
| |