lkml.org 
[lkml]   [2020]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] misc: cxl: flash: Remove unused variable 'drc_index'
    Hi Lee,

    I love your patch! Yet something to improve:

    [auto build test ERROR on char-misc/char-misc-testing]
    [also build test ERROR on soc/for-next linux/master linus/master v5.8-rc4 next-20200708]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use as documented in
    https://git-scm.com/docs/git-format-patch]

    url: https://github.com/0day-ci/linux/commits/Lee-Jones/Mop-up-last-remaining-patches-for-Misc/20200708-205913
    base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 8ab11d705c3b33ae4c6ca05eefaf025b7c5dbeaf
    config: powerpc-defconfig (attached as .config)
    compiler: powerpc64-linux-gcc (GCC) 9.3.0
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # save the attached .config to linux build tree
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc

    If you fix the issue, kindly add following tag as appropriate
    Reported-by: kernel test robot <lkp@intel.com>

    All errors (new ones prefixed by >>):

    drivers/misc/cxl/flash.c: In function 'update_devicetree':
    >> drivers/misc/cxl/flash.c:216:6: error: value computed is not used [-Werror=unused-value]
    216 | *data++;
    | ^~~~~~~
    cc1: all warnings being treated as errors

    vim +216 drivers/misc/cxl/flash.c

    172
    173 static int update_devicetree(struct cxl *adapter, s32 scope)
    174 {
    175 struct update_nodes_workarea *unwa;
    176 u32 action, node_count;
    177 int token, rc, i;
    178 __be32 *data, phandle;
    179 char *buf;
    180
    181 token = rtas_token("ibm,update-nodes");
    182 if (token == RTAS_UNKNOWN_SERVICE)
    183 return -EINVAL;
    184
    185 buf = kzalloc(RTAS_DATA_BUF_SIZE, GFP_KERNEL);
    186 if (!buf)
    187 return -ENOMEM;
    188
    189 unwa = (struct update_nodes_workarea *)&buf[0];
    190 unwa->unit_address = cpu_to_be64(adapter->guest->handle);
    191 do {
    192 rc = rcall(token, buf, scope);
    193 if (rc && rc != 1)
    194 break;
    195
    196 data = (__be32 *)buf + 4;
    197 while (be32_to_cpu(*data) & NODE_ACTION_MASK) {
    198 action = be32_to_cpu(*data) & NODE_ACTION_MASK;
    199 node_count = be32_to_cpu(*data) & NODE_COUNT_MASK;
    200 pr_devel("device reconfiguration - action: %#x, nodes: %#x\n",
    201 action, node_count);
    202 data++;
    203
    204 for (i = 0; i < node_count; i++) {
    205 phandle = *data++;
    206
    207 switch (action) {
    208 case OPCODE_DELETE:
    209 /* nothing to do */
    210 break;
    211 case OPCODE_UPDATE:
    212 update_node(phandle, scope);
    213 break;
    214 case OPCODE_ADD:
    215 /* nothing to do, just move pointer */
    > 216 *data++;
    217 break;
    218 }
    219 }
    220 }
    221 } while (rc == 1);
    222
    223 kfree(buf);
    224 return 0;
    225 }
    226

    ---
    0-DAY CI Kernel Test Service, Intel Corporation
    https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
    [unhandled content-type:application/gzip]
    \
     
     \ /
      Last update: 2020-07-08 20:16    [W:2.755 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site