Messages in this thread | | | From | Doug Anderson <> | Date | Wed, 8 Jul 2020 10:59:20 -0700 | Subject | Re: [PATCH] arm64: dts: qcom: sc7180: Drop the unused non-MSA SID |
| |
Hi,
On Tue, Jun 30, 2020 at 1:20 AM Sibi Sankar <sibis@codeaurora.org> wrote: > > Having a non-MSA (Modem Self-Authentication) SID bypassed breaks modem > sandboxing i.e if a transaction were to originate from it, the hardware > memory protections units (XPUs) would fail to flag them (any transaction > originating from modem are historically termed as an MSA transaction). > Drop the unused non-MSA modem SID on SC7180 SoCs and cheza so that SMMU > continues to block them. > > Fixes: bec71ba243e95 ("arm64: dts: qcom: sc7180: Update Q6V5 MSS node") > Fixes: 68aee4af5f620 ("arm64: dts: qcom: sdm845-cheza: Add iommus property") > Cc: stable@vger.kernel.org > Reported-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 +- > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-)
I'm not sure if my review is worth all that much since it's not my area of expertise, but as far as I can tell this is good / ready to go in. I've confirmed that a similar on my sc7180 board doesn't seem to break anything for me so restricting things like this seems sane.
Reviewed-by: Douglas Anderson <dianders@chromium.org> Tested-by: Douglas Anderson <dianders@chromium.org>
-Doug
| |