lkml.org 
[lkml]   [2020]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3/4] drm: edid: Convert logging to drm_* functions.
    From
    Date
    Thanks!

    Am 07.07.20 um 18:36 schrieb Suraj Upadhyay:
    > Change logging of warnings to drm_warn() form dev_warn().
    >
    > Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>

    Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

    > ---
    > drivers/gpu/drm/drm_edid.c | 7 +++----
    > 1 file changed, 3 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
    > index 31496b6cfc56..ad7a1f9817ed 100644
    > --- a/drivers/gpu/drm/drm_edid.c
    > +++ b/drivers/gpu/drm/drm_edid.c
    > @@ -1844,9 +1844,8 @@ static void connector_bad_edid(struct drm_connector *connector,
    > if (connector->bad_edid_counter++ && !drm_debug_enabled(DRM_UT_KMS))
    > return;
    >
    > - dev_warn(connector->dev->dev,
    > - "%s: EDID is invalid:\n",
    > - connector->name);
    > + drm_warn(connector->dev, "%s: EDID is invalid:\n", connector->name);
    > +
    > for (i = 0; i < num_blocks; i++) {
    > u8 *block = edid + i * EDID_LENGTH;
    > char prefix[20];
    > @@ -5284,7 +5283,7 @@ int drm_add_edid_modes(struct drm_connector *connector, struct edid *edid)
    > }
    > if (!drm_edid_is_valid(edid)) {
    > clear_eld(connector);
    > - dev_warn(connector->dev->dev, "%s: EDID invalid.\n",
    > + drm_warn(connector->dev, "%s: EDID invalid.\n",
    > connector->name);
    > return 0;
    > }
    >

    --
    Thomas Zimmermann
    Graphics Driver Developer
    SUSE Software Solutions Germany GmbH
    Maxfeldstr. 5, 90409 Nürnberg, Germany
    (HRB 36809, AG Nürnberg)
    Geschäftsführer: Felix Imendörffer

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-07-08 08:10    [W:4.216 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site