Messages in this thread | | | Date | Wed, 8 Jul 2020 19:20:17 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v3 0/2] synquacer: add TPM support |
| |
On Wed, Jul 08, 2020 at 10:14:22PM +0900, Masahisa Kojima wrote: > This adds support for driving the TPM on Socionext SynQuacer platform > using the driver for a memory mapped TIS frame. > > v3: > - prepare new module to handle TPM MMIO access on SynQuacer platform > > v2: > - don't use read/write_bytes() to implement read/write16/32 since that uses > the wrong address > > Cc: jarkko.sakkinen@linux.intel.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: ardb@kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-integrity@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: peterhuewe@gmx.de > Cc: jgg@ziepe.ca > > Masahisa Kojima (2): > tpm: tis: add support for MMIO TPM on SynQuacer > dt-bindings: Add SynQucer TPM MMIO as a trivial device > > .../devicetree/bindings/trivial-devices.yaml | 2 + > drivers/char/tpm/Kconfig | 12 ++ > drivers/char/tpm/Makefile | 1 + > drivers/char/tpm/tpm_tis_synquacer.c | 196 ++++++++++++++++++ > 4 files changed, 211 insertions(+) > create mode 100644 drivers/char/tpm/tpm_tis_synquacer.c > > -- > 2.20.1 >
Overally the code looks great. You've run it through checkpatch.pl?
/Jarkko
| |