lkml.org 
[lkml]   [2020]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 11/11] media: exynos4-is: Correct parallel port probing
From
Date
Hi,

On 26.04.2020 04:26, Jonathan Bakker wrote:
> According to the binding doc[1], port A should be reg = 0
> and port B reg = 1. Unfortunately, the driver was treating 0
> as invalid and 1 as camera port A. Match the binding doc and
> make 0=A and 1=B.
>
> [1] Documentation/devicetree/bindings/media/samsung-fimc.txt

Thank you for correcting this. I would prefer to correct the binding
documentation instead, so it says reg=1 for A and reg=2 for B.
Then it would also match what we have in dts for Goni and
enum fimc_input in include/media/drv-intf/exynos-fimc.h.


--
Regards,
Sylwester

\
 
 \ /
  Last update: 2020-07-08 18:16    [W:0.052 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site