lkml.org 
[lkml]   [2020]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] USB: serial: Use fallthrough pseudo-keyword
    Replace the existing /* fall through */ comments and its variants with
    the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
    fall-through markings when it is the case.

    [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    drivers/usb/serial/cypress_m8.c | 4 ++--
    drivers/usb/serial/io_edgeport.c | 4 ++--
    drivers/usb/serial/kobil_sct.c | 2 +-
    drivers/usb/serial/upd78f0730.c | 2 +-
    4 files changed, 6 insertions(+), 6 deletions(-)

    diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
    index 216edd5826ca..53e3051b0a71 100644
    --- a/drivers/usb/serial/cypress_m8.c
    +++ b/drivers/usb/serial/cypress_m8.c
    @@ -1046,7 +1046,7 @@ static void cypress_read_int_callback(struct urb *urb)
    return;
    case -EPIPE:
    /* Can't call usb_clear_halt while in_interrupt */
    - /* FALLS THROUGH */
    + fallthrough;
    default:
    /* something ugly is going on... */
    dev_err(dev, "%s - unexpected nonzero read status received: %d\n",
    @@ -1195,7 +1195,7 @@ static void cypress_write_int_callback(struct urb *urb)
    return;
    case -EPIPE:
    /* Cannot call usb_clear_halt while in_interrupt */
    - /* FALLTHROUGH */
    + fallthrough;
    default:
    dev_err(dev, "%s - unexpected nonzero write status received: %d\n",
    __func__, status);
    diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c
    index 4cca0b836f43..ba5d8df69518 100644
    --- a/drivers/usb/serial/io_edgeport.c
    +++ b/drivers/usb/serial/io_edgeport.c
    @@ -1752,7 +1752,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial,
    edge_serial->rxState = EXPECT_HDR2;
    break;
    }
    - /* Fall through */
    + fallthrough;
    case EXPECT_HDR2:
    edge_serial->rxHeader2 = *buffer;
    ++buffer;
    @@ -1804,7 +1804,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial,
    edge_serial->rxState = EXPECT_DATA;
    break;
    }
    - /* Fall through */
    + fallthrough;
    case EXPECT_DATA: /* Expect data */
    if (bufferLength < edge_serial->rxBytesRemaining) {
    rxLen = bufferLength;
    diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
    index e9882ba20933..9660c16be56a 100644
    --- a/drivers/usb/serial/kobil_sct.c
    +++ b/drivers/usb/serial/kobil_sct.c
    @@ -499,7 +499,7 @@ static void kobil_set_termios(struct tty_struct *tty,
    break;
    default:
    speed = 9600;
    - /* fall through */
    + fallthrough;
    case 9600:
    urb_val = SUSBCR_SBR_9600;
    break;
    diff --git a/drivers/usb/serial/upd78f0730.c b/drivers/usb/serial/upd78f0730.c
    index 1ba1401d27d7..0a2268c479af 100644
    --- a/drivers/usb/serial/upd78f0730.c
    +++ b/drivers/usb/serial/upd78f0730.c
    @@ -332,7 +332,7 @@ static void upd78f0730_set_termios(struct tty_struct *tty,
    tty->termios.c_cflag &= ~CSIZE;
    tty->termios.c_cflag |= CS8;
    dev_warn(dev, "data size is not supported, using 8 bits\n");
    - /* fall through */
    + fallthrough;
    case CS8:
    request.params |= UPD78F0730_DATA_SIZE_8_BITS;
    dev_dbg(dev, "%s - 8 data bits\n", __func__);
    \
     
     \ /
      Last update: 2020-07-07 21:53    [W:4.927 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site