lkml.org 
[lkml]   [2020]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] [PATCH 2/5] net: fec: enable to use PPS feature without time stamping
Date
From: Sergey Organov <sorganov@gmail.com> Sent: Monday, July 6, 2020 10:26 PM
> PPS feature could be useful even when hardware time stamping of network
> packets is not in use, so remove offending check for this condition from
> fec_ptp_enable_pps().

If hardware time stamping of network packets is not in use, PPS is based on local
clock, what is the use case ?

>
> Signed-off-by: Sergey Organov <sorganov@gmail.com>
> ---
> drivers/net/ethernet/freescale/fec_ptp.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index f8a592c..4a12086 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -103,11 +103,6 @@ static int fec_ptp_enable_pps(struct
> fec_enet_private *fep, uint enable)
> u64 ns;
> val = 0;
>
> - if (!(fep->hwts_tx_en || fep->hwts_rx_en)) {
> - dev_err(&fep->pdev->dev, "No ptp stack is running\n");
> - return -EINVAL;
> - }
> -
> if (fep->pps_enable == enable)
> return 0;
>
> --
> 2.10.0.1.g57b01a3

\
 
 \ /
  Last update: 2020-07-07 06:05    [W:0.262 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site