Messages in this thread | | | Subject | Re: [PATCH v2 4/6] selftests: pidfd: do not use ksft_exit_skip after ksft_set_plan | From | Shuah Khan <> | Date | Mon, 6 Jul 2020 14:55:16 -0600 |
| |
On 6/24/20 12:21 AM, Paolo Bonzini wrote: > On 23/06/20 22:44, Christian Brauner wrote: >>> ret = sys_pidfd_send_signal(pidfd, 0, NULL, 0); >>> if (ret < 0) { >>> - if (errno == ENOSYS) >>> - ksft_exit_skip( >>> + if (errno == ENOSYS) { >>> + ksft_test_result_skip( >>> "%s test: pidfd_send_signal() syscall not supported\n", >>> test_name); >> If pidfd_send_signal() is not supported, you're falling through and then >> you're reporting: >> >> ok 5 # SKIP pidfd_send_signal check for support test: pidfd_send_signal() syscall not supported >> ok 6 pidfd_send_signal check for support test: pidfd_send_signal() syscall is supported. Tests can be executed > > You're right, this needs a "return". >
Hi Paulo,
I am applying the rest of the patches in this series except this one. Please send v3 for this.
thanks, -- Shuah
| |